Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide optimizer directly to minimize, rather than type. #10

Closed
Rizhiy opened this issue Jun 9, 2022 · 0 comments · Fixed by #13
Closed

Provide optimizer directly to minimize, rather than type. #10

Rizhiy opened this issue Jun 9, 2022 · 0 comments · Fixed by #13

Comments

@Rizhiy
Copy link
Contributor

Rizhiy commented Jun 9, 2022

Adding new optimizers is quite cumbersome now, since I have to modify a dictionary in your module to add them.

It would be better if minimize was also able to take optimizer directly, instead of a type.

Will probably make a PR at some point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(mimizer.py): Allow passing optimizer class into minimize directly Rizhiy/benderopt
1 participant
@Rizhiy