Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add globstar support #21

Closed
wants to merge 1 commit into from
Closed

Conversation

oxinabox
Copy link

Closes #19

Right now this is attached to the x extended flag on FilenameMatch,
I do not know how to hook it to glob

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.0%) to 79.63% when pulling 1e4609f on oxinabox:ox/globstar into ed18d97 on vtjnash:master.

@vtjnash
Copy link
Owner

vtjnash commented Jan 23, 2019

This can't actually be hooked up to glob, since that actually will need a different (glob) algorithm to implement it (this doesn't close #19) and doesn't need any changes to fnmatch.

Since this doesn't appear to be in posix or gnu (and isn't actually relevant for globstar), I'm inclined to say no here, if that's OK with you.

@oxinabox
Copy link
Author

Saying no to this PR, I am down with. I wasn't sure it was right to begin with
and that was kinda why I openned it still WIP.

Saying no to #19 is giving up on one of the most useful features of bash's Glob that I miss all the time

@oxinabox oxinabox closed this Jan 23, 2019
@schneiderfelipe
Copy link

@vtjnash @oxinabox Couldn't this be implemented as a separate macro/function or requiring a flag? This way, the defaults would still comply with POSIX. This is really useful.

@vtjnash
Copy link
Owner

vtjnash commented Apr 9, 2021

The problem is that this PR doesn't really do anything useful, not that the concept (#19) is not useful. The implementation is required is just very different than this.

@vtjnash vtjnash mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlobStar support -- ** matches any number of levels
4 participants