Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failure #14

Closed
pgajdos opened this issue Jan 7, 2020 · 3 comments · Fixed by #15
Closed

test failure #14

pgajdos opened this issue Jan 7, 2020 · 3 comments · Fixed by #15

Comments

@pgajdos
Copy link

pgajdos commented Jan 7, 2020

Hello,

I get

$ libwhich libz.so.1
library:
  /lib64/libz.so.1

dependencies:
  linux-vdso.so.1
  /lib64/libdl.so.2
  /lib64/libc.so.6
  /lib64/ld-linux-x86-64.so.2
+ /lib64/libz.so.1
$

Note the linux-vdso.so.1 virtual iibrary in the output. Tests are not consider this possibility.
@pgajdos
Copy link
Author

pgajdos commented Jan 7, 2020

There is a patch here:
https://build.opensuse.org/package/view_file/home:pgajdos:julia/libwhich/libwhich-test.patch?expand=1
But not sure it is correct attitude.

vtjnash added a commit that referenced this issue Jan 7, 2020
@vtjnash
relax tests to ignore linux-vdso.so
348c4b3 
This is a fake library on linux, so we want to ignore it when looking for some real library to use in the tests.

Fix #14
@vtjnash vtjnash mentioned this issue Jan 7, 2020
Merged
@vtjnash
Copy link
Owner

vtjnash commented Jan 7, 2020

Thanks! Yeah, for some reason it didn't used to show up in the list. I've adapted something similar to that patch that'll ignore non-absolute paths showing up in the list.

vtjnash added a commit that referenced this issue Jan 7, 2020
@vtjnash
relax tests to ignore linux-vdso.so (#15)
87cffe1 
This is a fake library on linux, so we want to ignore it when looking for some real library to use in the tests.

Fix #14
@pgajdos
Copy link
Author

pgajdos commented Jan 8, 2020

Yes, that was second possibility I was considering. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

relax tests to ignore linux-vdso.so vtjnash/libwhich
2 participants
@vtjnash @pgajdos