Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx fee to the db and track for webhooks #71

Merged
merged 1 commit into from Jun 20, 2023
Merged

Conversation

vtnerd
Copy link
Owner

@vtnerd vtnerd commented May 26, 2023

Someone has privately requested that webhooks include the transaction fee. This was never reported by the MyMonero API, so the LWS-db doesn't even track it. This contains the first in-place update to the DB to get the transaction fee working.

Limitations:

  • Only ring-ct transactions are supported (Jan 2017). Older transactions will be reported as 0 for fee.
  • A rescan is not performed of existing transactions in the DB, instead the fee is marked as 0. A rescan will correctly update the fee.
  • The fee is not returned in the REST API, only the web hook API.

@vtnerd vtnerd merged commit eb81070 into develop Jun 20, 2023
vtnerd added a commit that referenced this pull request Nov 7, 2023
@vtnerd vtnerd deleted the feature/tx_fee branch February 18, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant