Add zero-confirmation support to webhooks (only) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a rebase on the branch - the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting zero-confirmation notifications via webhooks requires the
--suboption (andmonerodmust have--zmq-pubset as well). The transactions do not show up in the REST API until 1 confirmation. The notifications are nearly instant (everything uses pub/sub instead of polling).Zero-confirmations in the REST API might be added in the future but that is a little more involved (unless I can come up with an alternative implementation).
The block number and output numbers are omitted from zero-conf output, since they lack valid values.