-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to include licenses of Swift packages #101
Comments
Hello Martin, and thanks for your question! Unfortunately, you’re right: there’s no way to automatically include the SPM list of dependencies for a given project with AcknowList. Right now, you need to either hard-code the list (as an array of But that would be my top-priority feature request for AcknowList. The problem is that I’m not sure how to do it. To my knowledge, the best solution to find the list of resolved dependencies is to look at I know, lots of questions, but again, I think that’s the next step for AcknowList, as SPM seems to slowly overtake CocoaPods. |
Hi @vtourraine, thanks for sharing your thoughts on this. I understand now, it's tricky. I guess there is even no one-single-way of providing a license text as a Swift Package. However, having / including a list of packages is a good staring point & better than nothing, I would say. Generally speaking, I am a big fan of simply baking such kind of stuff into the app. So gathering everything at build time. However, fetching various license texts on every build sounds horrible. Taking into consideration that this process may even attempt different patterns such as Here is another idea:
Regards, Martin |
Alright, let’s do this 🚀 I’ve added a new branch: https://github.com/vtourraine/AcknowList/tree/parse-packages Right now, it only parses the titles and repository URLs from |
🤩 Awesome! Lemme know if there is anything I can help you with. |
Alright, I’ve opened a pull request with the new SPM support (with There’s also a good amount of refactoring, especially around |
Hey @vtourraine, I just gave it a first try and it works great so far. However, I am facing a crash on my private Swift packages, see https://github.com/vtourraine/AcknowList/pull/102/files#r893423676 pls. For me, it is easy to work around this by simply filtering my private packages, which I am about to do anyways. However, you may wanna add some kind of a URL validation to prevent client apps from crashing? Cheers, |
Hey @vtourraine how are things going on your side? I think PR #102 is done now, thus can get merged and eventually released. Bests, Martin |
Hello Martin, and thank you for your message. You’re right, the PR should be ready. I just didn’t have the time recently to check everything (documentation, breaking API changes, etc). I’ve blocked some time for next week, it should be merged then. Cheers 🙌 |
Update: it’s now merged into As previously discussed, this will be a “version 3” update, given the amount of interface changes. I’m thinking of releasing it alongside Xcode 14 in September. Probably not much that will change because of iOS 16/Swift 5.7 per se, but that’s always a nice time to move things forward. |
Hey there,
not sure if I just missed it in the docs... is there any way of automatically including the used swift packages as well.
In my App, I have only 2 dependencies left on Cocoapods while the rest are migrated to SPM. Would be great if it was somehow possible to mix both.
Cheers
The text was updated successfully, but these errors were encountered: