Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update and add basic repo automation #221

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

MarcHagen
Copy link
Contributor

Hi! Awesome project.

I've noticed that you are running quite old versions of the some docker build tools.
I've updated these in this PR.

Also added / changed the following.

  • Added CODEOWNERS; mainly for GitHub auto PR review notifications.
  • Added dependabot for github-actions; this will ensure it will be kept up to date.
  • Updated the docker build workflow:
    • Removed the wonky docker cache steps and added back type=ghacache. I/we use this and it works every good.
    • Added labels to the images; this will add opencontainer labels to the docker images. This is mainly useful for image scanners and other tooling (we use some)
    • Added the full version to the tags. (2.5.1, 2.5) so when you release a patch it will be uploaded to DockerHub separately.

Let me know if you have any questions or comments!
hoping to maybe contribute a little bit more in the future

Update version pins to more recent
Added labels, this will not hurt anything but gives opencontainer data to the container. Useful for docker image tracking.
Use GHA as docker layer cache, this will use the action cache of the repo to store interment layers. Way better than the local stuff and moving it afterwards.
@vtsykun vtsykun merged commit 6e5411e into vtsykun:master Feb 5, 2024
4 checks passed
@vtsykun
Copy link
Owner

vtsykun commented Feb 5, 2024

LGTM, thanks

@MarcHagen MarcHagen deleted the basic-automation branch February 5, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants