Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Return proper thac0 attack results when there is no target #504

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: Return proper thac0 attack results when there is no target #504

wants to merge 4 commits into from
+11 −12

Conversation

apewall
Copy link
Contributor

@apewall apewall commented Mar 4, 2024

Resolves #503

wyrmisis
wyrmisis approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@wyrmisis wyrmisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for hopping on this so quickly

@anthonyronda
Copy link
Member

Please see my comments on #503

anthonyronda
anthonyronda requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I pointed out in #503, users asked us for attacks without targets to always hit. I think if the expectation is for this to be considered a "bug," we first should address the requests raised in the other issues (#333 and #332) before jumping to a "fix" for this

src/module/helpers-dice.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyrmisis wyrmisis wyrmisis approved these changes

@anthonyronda anthonyronda Awaiting requested review from anthonyronda

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

THAC0 Providing Incorrect Feedback
3 participants
@apewall @anthonyronda @wyrmisis