Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (for port validation function) is missing in v0.6.4 release #45

Closed
omrid01 opened this issue Jan 3, 2024 · 1 comment
Closed

Fix (for port validation function) is missing in v0.6.4 release #45

omrid01 opened this issue Jan 3, 2024 · 1 comment

Comments

@omrid01
Copy link

omrid01 commented Jan 3, 2024

Following pull-request #37 by @knolleary, a fix was provided in release v0.6.4, to ensure the port validation function in the config node returns a Boolean value (required by Node-red as of v3.1.x)

I have installed v0.6.4, but the problem persists. Yet, when I patch the source file manually, the issue is resolved. Maybe the fix (which appears in the v0.6.4 release notes), has been omitted from the release?

The manual fix was to edit the file
"<Node-red home>\node_modules\node-red-contrib-oracledb-mod\lib\oracledb.html"
and replace
return v == null || v.match(/^(\s*|\d+|null)$/);
with
return v == null || !!v.match(/^(\s*|\d+|null)$/);

I am working on Windows, Node-red v3.1.3, Node-JS v20.10.0, NPM v10.2.3

@omrid01 omrid01 changed the title Fix (for port validation function) is missing in 0.6.4. release Fix (for port validation function) is missing in v0.6.4 release Jan 3, 2024
@omrid01 omrid01 closed this as completed Feb 20, 2024
@omrid01
Copy link
Author

omrid01 commented Feb 20, 2024

Fixed on v0.6.5.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant