Ensure port validation returns boolean #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtulluru
approved these changes
Dec 15, 2023
vtulluru
added a commit
that referenced
this pull request
Jan 3, 2024
On Wed, Jan 3, 2024 at 7:42 AM omrid01 <notifications@github.com> wrote: Following pull-request #37 by @knolleary, a fix was provided in release v0.6.4, to ensure the port validation function in the config node returns a Boolean value (required by Node-red as of v3.1.x) I have installed v0.6.4, but the problem persists. Yet, when I patch the source file manually, the issue is resolved. Maybe the fix (which appears in the v0.6.4 release notes), has been omitted from the release? The manual fix was to edit the file "\node_modules\node-red-contrib-oracledb-mod\lib\oracledb.html" and replace '''return v == null || v.match(/^(\s*|\d+|null)$/);withreturn v == null || !!v.match(/^(\s*|\d+|null)$/);``` I am working on Windows, Node-red v3.1.3, Node-JS v20.10.0, NPM v10.2.3
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port validation on
oracle-serverwasn't returning a boolean - it was relying on the truthiness of whatString.match()returns. Since Node-RED 3.1, if a validator returns an array, that is interpreted as a validation error (with the array containing reason messages). This means the config node is failing validation and it gets flagged as an error in the editor.This PR ensures the validation returns a boolean.