Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix effective batch size and zero grad #261

Merged
merged 9 commits into from
Jun 29, 2022
Merged

fix effective batch size and zero grad #261

merged 9 commits into from
Jun 29, 2022

Conversation

DonkeyShot21
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 15, 2022 •
edited

Codecov Report

Merging #261 (d266526) into main (bbf2d7e) will increase coverage by 0.05%.
The diff coverage is 56.00%.

Flag Coverage Δ *Carryforward flag
cpu 80.82% <52.38%> (-0.09%) ⬇️
dali 40.66% <50.00%> (ø) Carriedforward from bbf2d7e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/methods/linear.py 87.73% <40.00%> (-0.36%) ⬇️
solo/methods/base.py 78.51% <50.00%> (+0.08%) ⬆️
solo/args/utils.py 69.07% <75.00%> (+1.74%) ⬆️

@DonkeyShot21 DonkeyShot21 linked an issue Jun 28, 2022 that may be closed by this pull request
Check multi-node and fix lr #191
Closed
@DonkeyShot21 DonkeyShot21 merged commit b2fc210 into main Jun 29, 2022
@vturrisi vturrisi deleted the batch-size-and-zero-grad branch June 29, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vturrisi vturrisi vturrisi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check multi-node and fix lr
2 participants
@DonkeyShot21 @vturrisi