Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements MAE #278

Merged
merged 49 commits into from
Aug 7, 2022
Merged

Implements MAE #278

merged 49 commits into from
Aug 7, 2022

Conversation

vturrisi
Copy link
Owner

No description provided.

@vturrisi vturrisi marked this pull request as draft July 15, 2022 10:14
@codecov
Copy link

codecov bot commented Jul 15, 2022 •
edited

Codecov Report

Merging #278 (192849b) into main (5fd597d) will decrease coverage by 10.81%.
The diff coverage is 83.00%.

❗ Current head 192849b differs from pull request most recent head 65c6641. Consider uploading reports for the commit 65c6641 to get more accurate results

Flag Coverage Δ *Carryforward flag
cpu 82.13% <84.97%> (+0.25%) ⬆️
dali 40.06% <56.47%> (ø) Carriedforward from ee60f49

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/data/dali_dataloader.py 1.75% <0.00%> (ø)
solo/methods/mocov2plus.py 100.00% <ø> (ø)
solo/methods/mocov3.py 95.58% <ø> (ø)
solo/utils/__init__.py 64.70% <ø> (-18.63%) ⬇️
solo/args/utils.py 67.78% <16.66%> (-23.05%) ⬇️
solo/backbones/vit/vit_mocov3.py 79.45% <20.00%> (-20.55%) ⬇️
solo/data/h5_dataset.py 23.88% <33.33%> (ø)
solo/utils/misc.py 58.66% <54.41%> (-24.07%) ⬇️
solo/methods/base.py 77.61% <71.42%> (+2.39%) ⬆️
solo/args/setup.py 57.39% <80.00%> (-11.66%) ⬇️
... and 28 more

@vturrisi vturrisi marked this pull request as ready for review August 4, 2022 15:15
DonkeyShot21
DonkeyShot21 reviewed Aug 4, 2022
View reviewed changes
tests/methods/test_mae.py Outdated
"norm_pix_loss": True,
}

# BASE_KWARGS = gen_base_kwargs(cifar=False, momentum=True, batch_size=2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what?

@vturrisi vturrisi merged commit d105ab9 into main Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonkeyShot21 DonkeyShot21 DonkeyShot21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vturrisi @DonkeyShot21