Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dali_device option to the Resize op #311

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

ojss
Copy link
Contributor

@ojss ojss commented Nov 29, 2022

This will support running the Resize op on the GPU.

Using the vanilla Resize op fails without the device key since it runs on the CPU by default. A small change in the code fixes this.

cc/ @anujinho

this will support running the Resize op
on the GPU.
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #311 (b10a6ec) into main (1884bd7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ *Carryforward flag
cpu 81.42% <ø> (ø)
dali 39.38% <ø> (ø) Carriedforward from 1884bd7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/data/dali_dataloader.py 91.84% <ø> (ø)

Copy link
Owner

@vturrisi vturrisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it :)

@vturrisi vturrisi merged commit 6f19d5d into vturrisi:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants