-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WalletConnect v2 support #129
Comments
@re2005 Got it. Will prepare to migrate to the new version before the expiration date |
Awesome, I've tried quickly to make it work. Lots of typing and other stuff to fix: Also don't see |
@re2005 Hey, thanks for starting PR #133 and helping with the testing. To show my appreciation, I'd like to sponsor you with |
@re2005 great job! 😎 I can also send you some DAI if you provide the address 🤘 |
@chnejohnson @tempe-techie I really appreciate it. Will DM @chnejohnson with the |
Thanks @re2005 ❤️ & @chnejohnson for adding WalletConnect v2 support It seems that We had to updates these 2 lines to replace
Also, the So we had to replace this line: vue-dapp/src/connectors/walletConnect.ts Line 88 in cd4df36
with: this.#provider.on('chainChanged', (hexChainId: string) => {
const chainId = parseInt(hexChainId, 16); |
@goums Nice! I will fix it. Thanks for your sharing! |
fix: fix some bugs about walletconnect v2, resolve #129
🎉 This issue has been resolved in version 0.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Seems like we a using a deprecated version of
WalletConnect
We should use
@walletconnect/web3wallet
The text was updated successfully, but these errors were encountered: