feat: make chain list extendable #59
Conversation
✅ Deploy Preview for vue-dapp ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-dapp-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
It looks good, seems that you just remain |
|
It's just a suggestion, maybe this plugin shouldn't take the responsibility of managing the networks, also because there are too many and on each project they will be different. But also the information, per chain that devs needs will be different for their needs. So you can let users to just input their networks/chains and don't deal with that. |
|
Make sense, I like this extendable feature, but I prefer to remain |
|
@re2005 Hey, I changed my mind. Just remaining |
|
Yes, this makes sense. I can help with the docs if @re2005 can't. The best would be to have a It makes sense to have Ethereum and its testnets (Goerli) added by default in the plugin (because they use |
|
Something other lib do provide a list of most common chains. So you can import everything or just the ones you need. Check: it's all in there. |
re2005
force-pushed
the
feature/init-parameters-for-chains
branch
from
c9196f3
to
685b655
Compare
|
Hey @chnejohnson So finally i'm running on a valid/good use case. My application supports some networks that are not "inside" Check: This Pr will also fix that allowing the extension of the network list. I've added some documentation as well. (@tempe-techie please help out if you think documentation needs more details) Please review and let's merge it. |
re2005
force-pushed
the
feature/init-parameters-for-chains
branch
from
dab4cf1
to
ecf088a
Compare
Looks good! Thanks! 🎉 🤘 😎 |
There was a problem hiding this comment.
Hey @re2005, thanks for your good work!
I reviewed the code and found a few bugs (probably made by my hand), but it's fine to fix it later. The main problem is that you have to drop the last commit:d74597( Merge branch main...) and run git rebase -i main on commit:ecf088 and fix a simple conflict. So it will be more clear in the git history.
In addition to what's mentioned above, it looks good to me 👍
re2005
force-pushed
the
feature/init-parameters-for-chains
branch
2 times, most recently
from
121a839
to
ccacec6
Compare
|
@chnejohnson Thanks for the review 🙏 I hope It's all fixed now. |
re2005
force-pushed
the
feature/init-parameters-for-chains
branch
from
ccacec6
to
34e3802
Compare
Update Board.vue Update useEthers.ts Update chainId.ts Update App.vue chore: extendable networks option chore: update docs Update index.md Update README.md fix: url and symbol Update README.md Update index.md
re2005
force-pushed
the
feature/init-parameters-for-chains
branch
from
34e3802
to
d9e47c9
Compare
|
@re2005 Perfect! |
The available network list is essential on every application, but they are so many, so better reduce it to a few and let the user extend it as it needs.
Please share ideas here.