feat: add ens support #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-dapp ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-dapp-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| chainId: number, | ||
| address: string, | ||
| _provider?: Web3Provider, | ||
| ) { |
There was a problem hiding this comment.
How about if another parameter is added here (service)? To specify a web3 domain service? ENS can be specified by default, but others can be added later on such as Unstoppable Domains, Punk Domains etc.
There was a problem hiding this comment.
Good advice. This function serves to output the return value from the common/default DNS set. Providing more custom slots would be excellent, maybe I'll tweak it later.
re2005
approved these changes
Aug 3, 2022
|
LGTM, thanks for your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Despite the fact that ens is not widely used, there is still the option of trying to add ens nicknames to the display.
Maybe this will be a trend too, who knows.
Proposed Solution
Add DNS alias such as ENS.
Additional Information
This is an experimental feature.