Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bstatgen 1057 date time classes #7

Merged
merged 19 commits into from
Mar 1, 2023
Merged

Bstatgen 1057 date time classes #7

merged 19 commits into from
Mar 1, 2023

Conversation

obregos
Copy link
Collaborator

@obregos obregos commented Mar 1, 2023

  • add handlers argument to fieldToVar
  • update description
  • add test cases

obregos and others added 19 commits February 24, 2023 07:53
@obregos
add handlers option to function
f0d4ffb
@obregos
add variable arg list (...) to fieldToVar calls, update documentation
4e2d9f5
@spgarbet
Minor edits to DESCRIPTION and urls
d03af82
@spgarbet
Added explict list of field types supported
d741e97
@spgarbet
Adding documentation on ellipsis argument to pass CRAN checks for fie…
6c90d8f 
…ldToVar
@spgarbet
Reworking test cases to use keyring versus our QA database
5af3175
@spgarbet
Added another skip_on_cran() to a test
5a73adc
@spgarbet
Got tests working versus local test instance
820969f
@spgarbet
Minor spacing changes
1273deb
@obregos
add test cases for fieldToVar dates, times and datetimes classes
d299404
@spgarbet
Modified README for new package status
77cae26
@spgarbet
Removed run_on_cran() since this is handled by .RBuildIgnore
fe2db6f
@obregos
use numeric function to test
1d12d7a
@obregos
passing test cases
faba442
@spgarbet
Testing backend_file for MACOS issue
b5df313
@obregos
place all handlers in single call
aa00a5d
@obregos
format to class times for time_hhmmss when dates = TRUE
4944a0b
@spgarbet
Added tests for specific values in REDCap for fieldToVar
879019d
@spgarbet
Added more failToVar tests of returned first record
82c298e
spgarbet
spgarbet approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@spgarbet spgarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@spgarbet spgarbet merged commit 9b2b469 into main Mar 1, 2023
@spgarbet
Copy link
Member

spgarbet commented Mar 1, 2023

Closes Issue #6

spgarbet pushed a commit that referenced this pull request Mar 17, 2023
@nutterb
Merge pull request #7 from nutterb/rcon-caching
6cefb2d 
remove vectorToApiBodyList from exports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spgarbet spgarbet spgarbet approved these changes

@harrelfe harrelfe Awaiting requested review from harrelfe

Assignees

@spgarbet spgarbet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@obregos @spgarbet