Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast removes the overlay #405

Closed
mdominiak2 opened this issue Nov 21, 2023 · 1 comment · Fixed by #412
Closed

Toast removes the overlay #405

mdominiak2 opened this issue Nov 21, 2023 · 1 comment · Fixed by #412
Assignees
@hunterliu1003
Labels
bug Something isn't working

Comments

@mdominiak2
Copy link

Version

vue-final-modal: 4.4.6
vue: 3
nuxt: 3.1.0

OS

Windows

Reproduction Link

https://stackblitz.com/edit/github-zz9sxc?file=pages%2Findex.vue

Steps to reproduce

  1. Open modal
  2. Click Open toast

What is Expected?

Toast is shown over the overlay

What is actually happening?

Overlay disappear
@mdominiak2 mdominiak2 added the bug Something isn't working label Nov 21, 2023
hunterliu1003 added a commit that referenced this issue Dec 1, 2023
@hunterliu1003
feat: add overlayBehavior prop to VueFinalModal #405
dafa559
@hunterliu1003 hunterliu1003 mentioned this issue Dec 1, 2023
Merged
hunterliu1003 added a commit that referenced this issue Dec 7, 2023
@hunterliu1003 @AdamMerrifield @Mini-ghost
Feat/4.5 (#413)
73255d0 
* rename module extension to mjs

* chore: update lock file

* fix: fixed generic component type in useModal composable

* docs: update type

* chore: bump deps

* fix: bump deps

* chore: update example/nuxt3

* docs: #385

* fix: #390

* chore: use vite-plugin-dts to build lib

* feat: add `stop()` for `@beforeOpen` and `beforeClose` event #367

* refactor: move watch modelValueLocal into setModelValueLocal

* fix: setModelValueLocal and add StopEvent example

* perf: use getter and setter instead of `computed` for `modelValueLocal`

* docs: add event.stop() back

* refactor: delete CoreModal, this will also fixed #362

* refactor: improve type, lint, cleanup

* feat: add overlayBehavior prop to VueFinalModal #405

* refactor: rename type Modal to ModalExposed

* chore: fix nestedModal viteplay example

* fix: overlayBehavior

* feat: add close function to defineSlots

* docs: scoped slots close

* chore: reduce bundle size a bit

---------

Co-authored-by: AdamMerrifield <adam.merrifield@gmail.com>
Co-authored-by: Alex Liu <dsa1314@gmail.com>
@hunterliu1003
Copy link
Member

@mdominiak2 Please upgrade to v4.5.0
The bug is fixed. Here is an example: https://stackblitz.com/edit/github-zz9sxc-6r4lnn?file=package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hunterliu1003 hunterliu1003

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/405 vue-final/vue-final-modal
2 participants
@hunterliu1003 @mdominiak2