Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big fix: v3 - Remove event listeners in abstractField for current context only #546

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

gapipro
Copy link

@gapipro gapipro commented Nov 13, 2018

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Instead of removing all event listeners for specific event, we just remove the ones that are relevant to current context.
  • What is the current behavior?
    When different fields get unmounted/destroyed they clear all event listeners for certain events like 'validate-fields'. This results in form validation not working after field removal until some other field is added back.
  • What is the new behavior (if this is a feature change)?
    Field removals no longer effect form validation.
  • *Does this PR introduce a breaking change?
    No
  • Other information:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.92% when pulling ffb839f on gapipro:v3 into 2b4ab0b on vue-generators:v3.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.92% when pulling ffb839f on gapipro:v3 into 2b4ab0b on vue-generators:v3.

@zoul0813
Copy link
Member

@lionel-bijaoui can you check this out?

@zoul0813 zoul0813 merged commit 218baba into vue-generators:v3 Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants