Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new texture component. #43

Merged
merged 7 commits into from
Nov 9, 2017
Merged

The new texture component. #43

merged 7 commits into from
Nov 9, 2017

Conversation

h-ikeda
Copy link
Member

@h-ikeda h-ikeda commented Nov 2, 2017

For #42 .

The namespace and re-rendering strategies are also modified to render at the appropriate timing.

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #43 into master will increase coverage by 3.05%.
The diff coverage is 98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   92.38%   95.43%   +3.05%     
==========================================
  Files          35       37       +2     
  Lines         289      307      +18     
==========================================
+ Hits          267      293      +26     
+ Misses         22       14       -8
Impacted Files Coverage Δ
src/vgl-spot-light.js 94.73% <100%> (+0.61%) ⬆️
src/vgl-namespace.js 100% <100%> (ø) ⬆️
src/vgl-point-light.js 100% <100%> (ø) ⬆️
src/vgl-camera.js 90% <100%> (+10%) ⬆️
src/vgl-orthographic-camera.js 100% <100%> (ø) ⬆️
src/vgl-light.js 100% <100%> (ø) ⬆️
src/vgl-perspective-camera.js 100% <100%> (ø) ⬆️
src/vgl-mesh-standard-material.js 100% <100%> (ø) ⬆️
src/vgl-texture.js 100% <100%> (ø)
src/utils.js 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba87f12...8fcb5b4. Read the comment docs.

@h-ikeda
Copy link
Member Author

h-ikeda commented Nov 2, 2017

The VglBoxHelper component example does not work.

@h-ikeda h-ikeda merged commit 86cc291 into master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant