Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid key "custom" in validation rules object for prop "XYZ". #109

Closed
Ankit-Dave opened this issue Dec 15, 2017 · 5 comments
Closed

Invalid key "custom" in validation rules object for prop "XYZ". #109

Ankit-Dave opened this issue Dec 15, 2017 · 5 comments

Comments

@Ankit-Dave
Copy link

Description

When importing components vue esm is giving warnings as custom is not valid prop key.
as they have added the check for "warn misspelled keys on prop validation object"
vuejs/vue@d02bb37

Steps to Reproduce

Use vue: v2.5.11
https://github.com/vuejs/vue/releases

Browsers Affected

  • [.] Chrome
  • [.] Firefox
  • [.] Edge
  • [.] Safari 9
  • [.] Safari 8
  • [.] IE 11

Versions

  • Leaflet: v1.2.0
  • Vue: v2.5.11
  • Vue2Leaflet: v0.0.57
@wuxiashuangji
Copy link

wuxiashuangji commented Dec 15, 2017


qq 20171215191345
me too
and
Vue: v2.5.11 instead Vue: v2.5.10 is ok

@asifm
Copy link

asifm commented Dec 17, 2017

Yes, it's happening everywhere.

I believe it's related to these changes in the new release https://github.com/vuejs/vue/releases

Improvements

warn misspelled keys on prop validation object (#7198) d02bb37, closes vuejs/vue#7198

@KoRiGaN
Copy link
Collaborator

KoRiGaN commented Dec 19, 2017

Yes, it seems the Vue now check properties to look exactly like in the documentation.

Vue2Leaflet is using a key called "custom" in the property in order to bind it to the method of the Vue2Leaflet object or the method of the underlying leaflet object.

It seems that you can no longer do that with Vue so I need to find a new way of doing this...
You can still use Vue v2.5.10 in the meanwhile.

Mickaël

@alexcode
Copy link

@asifm @KoRiGaN, the props validation has been remove in Vuejs v2.5.13 as per this diff.

@KoRiGaN
Copy link
Collaborator

KoRiGaN commented Jan 16, 2018

Closing as it should no longer be an issue with the last vue version.

@KoRiGaN KoRiGaN closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants