-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marker isn't reactive after updating vue2-leaflet #274
Comments
Oh, I found that this is also happened without using Vuex store.
|
@jkatagi thank you for the issue, I will take a look! |
@jkatagi I see, before it was working due to the object being passed by reference. |
@jkatagi I am about to release a new version that includes a fix for this issue. |
@lordfuoco Thank you very much for you help! I'm waiting your release! |
Are we sure this is fixed? If you drag a marker now, the newly introduced 100 debounce seems reasonable, but there isn't an update to the last set position, so when you drop a marker, the lat-lng is not the final position it visually LOOKS like it is at. |
@alexbainbridge yes it should be fixed as I see the events emitted on the vue panel, are you using .sync modifier ? Before there were side effects that are not nice |
@lordfuoco Hi ! Its the debounce that is the problem Thinking outloud - would throttle work (rather than debounce?). Or could you leave throttling / debouncing to the parent code? |
@alexbainbridge Oh so is an error of the debounce function that I wrote, because it should be sent out with the latest value and not others! Thanks for the headsup |
Sounds like you have this - but do you want me to open an issue? Or you reopen this one? Thanks! |
@alexbainbridge we are not issue shy! Go on open it please, because I am swamped and I could forget if there is not an issue open :) thank you very much. For the future, just go on and open an issue if you think there is a bug / mismatch / misalignment. |
Description
I updated vue2-leaflet from v1.0.2 to v1.1.1 but after updating, marker isn't reactive.
I manage the marker's latlng in stores to update it from other components (e.x. from Exif information of pictures), so the code is a little complicated.
Could you tell me what happened? thanks.
Live Demo
Steps to Reproduce
See jsfiddle.
Expected Results
Actual Results
Browsers Affected
Versions
The text was updated successfully, but these errors were encountered: