Typescript support

[andi23rosca]

@DonNicoJs Maybe too early to start a conversation about it since you have just started the implementation, but would it make sense to write the whole codebase in Typescript?
Since Vue 3 will basically have better support for type checking especially in the templates.

[DonNicoJs]

@andi23rosca I think is a good idea, but I am not as fluent in typescript as in javascript! What do you think if we first reach an alpha phase and then try to rewrite it? by using composition API it should be quite straightforward

[andi23rosca]

@DonNicoJs Sounds good, I have just finished porting a large Vue codebase to Typescript so I think I can help when the time comes. It's nice that there's already types for Leaflet so we don't really need to do much work.

[lukkyjoe]

hi, pardon me if I'm parachuting in with a non-valuable suggestion, but at work we have begun migrating some js codebases to ts using ts-migrate. results have been mostly positive.
so that is just to say that if for alpha you stick to js (which i totally understand it keeps things simpler and more narrowly scoped), there are tools that help you migrate later. don't have to feel like the window must be now.

[DonNicoJs]

@lukkyjoe This is a very good input! Thank you! I will look into it

[jsbroks]

I definitely think typescript support is a must, since this is the direction Vue (and the community) is going.

[reinier-millo]

It can be added to use with typescript support and keep developing it as JS, you need to provide the module declaration file.

[reinier-millo]

I have to use it on one project and have added the following definition to my project

declare module '@vue-leaflet/vue-leaflet' {
  import type { DefineComponent } from 'vue';
  export const LMap: DefineComponent;
  export const LIcon: DefineComponent;
  export const LTileLayer: DefineComponent;
  export const LMarker: DefineComponent;
  export const LControlLayers: DefineComponent;
  export const LTooltip: DefineComponent;
  export const LPopup: DefineComponent;
  export const LPolyline: DefineComponent;
  export const LPolygon: DefineComponent;
  export const LRectangle: DefineComponent;
}

And it's working, but handling components as general (any) component.

[jsbroks]

The solution mention above will only provide SOME typescript support. This will not add typing to components props.

@DonNicoJs I can go though and convert the files to typescript, but we should also conside removing the use of .vue files for better ts integration.

[ghost]

Any news about typescript support ?

[leegee]

Any news about typescript support? Lack thereof is making it hard/impossible to sell Vue with Leaflet.

[talentamaulana10]

where's the typescript support !?

[leegee]

I switched to OpenLayers.

[aisiklar]

I have to use it on one project and have added the following definition to my project

declare module '@vue-leaflet/vue-leaflet' {
  import type { DefineComponent } from 'vue';
  export const LMap: DefineComponent;
  export const LIcon: DefineComponent;
  export const LTileLayer: DefineComponent;
  export const LMarker: DefineComponent;
  export const LControlLayers: DefineComponent;
  export const LTooltip: DefineComponent;
  export const LPopup: DefineComponent;
  export const LPolyline: DefineComponent;
  export const LPolygon: DefineComponent;
  export const LRectangle: DefineComponent;
}

And it's working, but handling components as general (any) component.

Hi Reinier-millo,
where did you create the above script in? I am really so unfamiliar to typescript but I want to use vue-leafler in an vue-electron template where the lang is ts...
Thanks in advance