fix(better-define): cycle imports on HMR

closes #227
vue-macros · Jan 24, 2023 · 0ec95df · 0ec95df
1 parent 60093ab
commit 0ec95df
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/odd-kids-rule.md b/.changeset/odd-kids-rule.md
@@ -0,0 +1,5 @@
+---
+'@vue-macros/better-define': patch
+---
+
+fix cycle imports on HMR
diff --git a/packages/better-define/src/index.ts b/packages/better-define/src/index.ts
@@ -103,9 +103,13 @@ export default createUnplugin<Options | undefined, false>(
         },
 
         handleHotUpdate({ file, server, modules }) {
+          const cache = new Map<string, Set<ModuleNode>>()
           function getAffectedModules(file: string): Set<ModuleNode> {
+            if (cache.has(file)) return cache.get(file)!
+
             if (!referencedFiles.has(file)) return new Set([])
             const modules = new Set<ModuleNode>([])
+            cache.set(file, modules)
             for (const importer of referencedFiles.get(file)!) {
               const mods = server.moduleGraph.getModulesByFile(importer)
               if (mods) mods.forEach((m) => modules.add(m))