fix(better-define): hmr

closes #158
vue-macros · Nov 23, 2022 · 2fa0808 · 2fa0808
1 parent 6f5f652
commit 2fa0808
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/.changeset/happy-books-share.md b/.changeset/happy-books-share.md
@@ -0,0 +1,5 @@
+---
+'@vue-macros/better-define': patch
+---
+
+fix HMR
diff --git a/packages/better-define/src/index.ts b/packages/better-define/src/index.ts
@@ -90,7 +90,7 @@ export default createUnplugin<Options | undefined>((userOptions = {}, meta) => {
         options.isProduction = config.isProduction
       },
 
-      handleHotUpdate({ file, server }) {
+      handleHotUpdate({ file, server, modules }) {
         function getAffectedModules(file: string): Set<ModuleNode> {
           if (!referencedFiles.has(file)) return new Set([])
           const modules = new Set<ModuleNode>([])
@@ -105,8 +105,8 @@ export default createUnplugin<Options | undefined>((userOptions = {}, meta) => {
 
         if (tsFileCache[file]) delete tsFileCache[file]
 
-        const modules = getAffectedModules(file)
-        return Array.from(modules)
+        const affected = getAffectedModules(file)
+        return [...modules, ...affected]
       },
     },
   }

diff --git a/playground/vue3/src/examples/better-define/another-types.ts b/playground/vue3/src/examples/better-define/another-types.ts
@@ -1,3 +1,3 @@
 export type AnotherType = {
-  baz: string
+  baz?: string
 }
diff --git a/playground/vue3/src/examples/better-define/child.vue b/playground/vue3/src/examples/better-define/child.vue
@@ -24,7 +24,5 @@ defineEmits<Emits>()
 </script>
 
 <template>
-  <div>
-    <slot />
-  </div>
+  <div>bar</div>
 </template>