Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-directive): v-if and v-for co-usage #445

Merged
merged 6 commits into from Aug 7, 2023

Conversation

zhiyuanzmj
Copy link
Member

No description provided.

@stackblitz
Copy link

stackblitz bot commented Aug 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2023

🦋 Changeset detected

Latest commit: 9a556f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@vue-macros/jsx-directive Minor
@vue-macros/volar Patch
unplugin-vue-macros Patch
@vue-macros/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓 Some comments left for you

packages/common/src/constants.ts Outdated Show resolved Hide resolved
packages/jsx-directive/src/core/index.ts Outdated Show resolved Hide resolved
@sxzz sxzz changed the title fix(jsx-directive): v-if can't be used with v-for fix(jsx-directive): v-if and v-for co-usage Aug 7, 2023
@sxzz sxzz enabled auto-merge (squash) August 7, 2023 06:28
@sxzz sxzz merged commit b8b314e into vue-macros:main Aug 7, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
@zhiyuanzmj zhiyuanzmj deleted the fix/jsx-directive branch August 7, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants