Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(volar): support defineSlots for vue2 #525

Merged
merged 7 commits into from Oct 24, 2023
Merged

Conversation

zhiyuanzmj
Copy link
Member

Description

closed #524

Linked Issues

Additional context

@stackblitz
Copy link

stackblitz bot commented Oct 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

🦋 Changeset detected

Latest commit: 2f3bf74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vue-macros/volar Patch
@vue-macros/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-macros ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 1:54am

@zhiyuanzmj
Copy link
Member Author

Wait for volar v1.8.20, the ts-error with defineSlots in vue2 will be fixed.
vuejs/language-tools#3669 (comment)

@sxzz
Copy link
Member

sxzz commented Oct 23, 2023

@zhiyuanzmj v1.8.20 is released & upgraded in Vue Macros.

@zhiyuanzmj
Copy link
Member Author

Ok, TBR.

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxzz sxzz merged commit e425c90 into main Oct 24, 2023
7 checks passed
@sxzz sxzz deleted the feat/volar-vue2-define-slots branch October 24, 2023 14:35
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsxDirective v-slot and defineSlots in Vue 2 are incompatible
2 participants