Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-directive): add bracket for ternary expression in v-if #559

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

zhiyuanzmj
Copy link
Member

Description

<div v-if={foo === 0}>0</div>
// Transform to
{(foo === 1) ? <div>1</div> : null}

Linked Issues

Additional context

Copy link

stackblitz bot commented Nov 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: f648553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@vue-macros/jsx-directive Patch
@vue-macros/volar Patch
unplugin-vue-macros Patch
@vue-macros/nuxt Patch
@vue-macros/astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vue-macros ✅ Ready (Inspect) Visit Preview Nov 16, 2023 7:29am

@sxzz sxzz changed the title fix(jsx-directive): incorrect execution order of the ternary expression in v-if fix(jsx-directive): add bracket for ternary expression in v-if Nov 16, 2023
@sxzz sxzz merged commit a4b1b6b into main Nov 16, 2023
8 checks passed
@sxzz sxzz deleted the fix/ternary-operator branch November 16, 2023 07:33
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants