Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non redirect confirm emit continued (Follow up on #288) #299

Merged

Conversation

peterpacket
Copy link
Contributor

Follow up for #269

Since PR #288 seems to be inactive, here are the requested changes. It would be very awesome if this PR could be merged, as I need this functionality for my current project.

Original PR content

Follow up for https://github.com/vue-stripe/vue-stripe/issues/269

Tested, works

If the user has passed prop redirect="if_required" and the payment confirmation was successful and the payment method is not forced to redirect then stripe.confirmPayment resolves with a paymentIntent so we sould pass it back up to the caller for consumption:
https://stripe.com/docs/js/payment_intents/confirm_payment?type=pii#confirm_payment_intent-options-redirect

@xpresas
Copy link

xpresas commented Nov 28, 2022

This is actually needed. I use vue stripe in a modal and no redirect method works for me too. Altho I dont have any response to actually close the modal when payment is done. So $emit confirmed would help me too!

Copy link
Member

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thank you so much for this.

@jofftiquez jofftiquez merged commit caa15a1 into vue-stripe:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants