feat: add slot support in jsx render function #101
Conversation
| const renderValuePath = renderPath[0].get('value') | ||
| const renderValuePath = bt.isObjectProperty(renderPath[0].node) | ||
| ? renderPath[0].get('value') | ||
| : renderPath[0] | ||
| recast.visit(renderValuePath, { |
There was a problem hiding this comment.
Since you can return JSX from both methods and computed properties (and maybe even data?), I think we should visit the full Vue object here.
There was a problem hiding this comment.
It'll make the PR bigger though since we need to add all the relevant tests
There was a problem hiding this comment.
that is a good idea. In this case, you should create another handler so that not to polute the render function handler already present.
| @@ -95,6 +95,8 @@ export default { | |||
| const { sortKey, capitalize } = this | |||
| return ( | |||
| <table class="grid"> | |||
| {/** @slot Use this slot header */} | |||
| <slot name="header" /> | |||
There was a problem hiding this comment.
Perhaps also add a method/computed property with the footer slot, and then include it below. See my comment above
|
Hello @b12f, You review is very appreciated. :-) |
Co-Authored-By: elevatebart <ledouxb@me.com>
|
Feel free to merge, I'll look at how we might be able to do full component parsing. |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fix #100