Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[data-picker]: hide Now when current time is disabled #6152

Closed
wants to merge 1 commit into from
Closed

fix[data-picker]: hide Now when current time is disabled #6152

wants to merge 1 commit into from

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Dec 11, 2022

First of all, thank you for your contribution! 😄

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Changelog description (Optional if not new feature)

Chinese description (optional)
disableDate 函数里设置,今天是不可选的。但是,当你点击 Now ,你依然可以设置时间为今天。并且点击 Now 按钮,之后并不需要你点击 ok 去赋值,是点击完 Now 按钮之后一步完成了。所以有两种解决方案我认为:

  • 如果当前时间 invalid,就隐藏 Now
  • 点击 Now 按钮之后,不立即关闭这个 panel,需要点击 ok 后才关闭这个 panel

我比较倾向于第一种。

@kovsu
Copy link
Member Author

kovsu commented Dec 11, 2022

image
当我没选择日期,去选择 时间 的时候,会将 日期 设置为今天。但是 确定 按钮还是 disabled,就防止了错误的发生。
所以我觉得能产生问题的就只有这个 Now 按钮

@kovsu kovsu closed this by deleting the head repository Jan 13, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a-date-picker component bug
1 participant