feat: remove typescript extension patch (#7)

* feat: remove patch typescript * fix: remove command configuration Co-authored-by: Rahul Kadyan <hi@znck.me>
vuedx · Apr 19, 2020 · 08141a5 · 08141a5
1 parent 214b8fa
commit 08141a5
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 136 deletions.
diff --git a/extensions/vue-language-features/package.json b/extensions/vue-language-features/package.json
@@ -10,7 +10,6 @@
   "main": "dist/extension.js",
   "activationEvents": [
     "onLanguage:vue",
-    "onCommand:vue.patchTypeScript",
     "onCommand:vue.openVirtualFile"
   ],
   "scripts": {
@@ -37,10 +36,6 @@
       {
         "command": "vue.openVirtualFile",
         "title": "Vue: Show virtual file"
-      },
-      {
-        "command": "vue.patchTypeScript",
-        "title": "Vue: Patch TypeScript extension"
       }
     ],
     "menus": {
@@ -84,7 +79,47 @@
           "vue"
         ]
       }
-    ]
+    ],
+    "configuration": {
+      "title": "Vue",
+      "properties": {
+        "typescript-plugins.suggest.enabled": {
+          "type": "boolean",
+          "default": true,
+          "description": "Enabled/disable autocomplete suggestions.",
+          "scope": "resource"
+        },
+        "typescript-plugins.format.enable": {
+          "type": "boolean",
+          "default": true,
+          "description": "Enable/disable default TypeScript/JavaScript formatter.",
+          "scope": "window"
+        },
+        "typescript-plugins.implementationsCodeLens.enabled": {
+          "type": "boolean",
+          "default": false,
+          "description": "Enable/disable implementations CodeLens. This CodeLens shows the implementers of an interface.",
+          "scope": "window"
+        },
+        "typescript-plugins.suggest.completeJSDocs": {
+          "type": "boolean",
+          "default": true,
+          "description": "Enable/disable suggestion to complete JSDoc comments.",
+          "scope": "resource"
+        },
+        "typescript-plugins.referencesCodeLens.enabled": {
+          "type": "boolean",
+          "default": false,
+          "description": "Enable/disable references CodeLens in TypeScript/JavaScript files.",
+          "scope": "window"
+        },
+        "typescript-plugins.autoClosingTags": {
+          "type": "boolean",
+          "default": true,
+          "description": "Enable/disable automatic closing of JSX tags. Requires using TypeScript 3.0 or newer in the workspace."
+        }
+      }
+    }
   },
   "bugs": {
     "url": "https://github.com/znck/vue-developer-experience/issues"

diff --git a/extensions/vue-language-features/src/commands/patchTypeScript.ts b/extensions/vue-language-features/src/commands/patchTypeScript.ts
diff --git a/extensions/vue-language-features/src/index.ts b/extensions/vue-language-features/src/index.ts
@@ -4,7 +4,6 @@ import { Container } from 'inversify';
 import { ConfigurationService } from '@vuedx/extensions-shared/services/configuration';
 import { DocumentService } from '@vuedx/extensions-shared/services/documents';
 import { OpenVirtualFileCommand } from './commands/openVirtualFile';
-import { PatchTypeScriptCommand } from './commands/patchTypeScript';
 import { VueVirtualDocumentProvider } from './scheme/vue';
 
 export async function activate(context: vscode.ExtensionContext) {
@@ -16,7 +15,6 @@ export async function activate(context: vscode.ExtensionContext) {
     container.get(ConfigurationService).install(),
     container.get(VueVirtualDocumentProvider).install(),
     container.get(OpenVirtualFileCommand).install(),
-    container.get(PatchTypeScriptCommand).install(),
     // clean container.
     new vscode.Disposable(() => container.unbindAll())
   );