Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on empty mask using directive #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgesmundo
Copy link

This PR disable the masking when the mask is empty using v-mask directive.
All the best

@nogueiraever
Copy link

nice, I was already seen this error.

thanks

This was referenced Oct 25, 2017
@zhiga90
Copy link

zhiga90 commented Nov 1, 2017

+1

1 similar comment
@bxavier
Copy link

bxavier commented Nov 30, 2017

+1

@talski
Copy link

talski commented Dec 6, 2017

+1, won't it be merged?

@minatonda
Copy link

+1

1 similar comment
@fabriciobeltran
Copy link

+1

@EdwinHauspie
Copy link

still waiting ....

@minatonda
Copy link

@neves

@jsonantunes
Copy link

+1

1 similar comment
@lucassimines
Copy link

+1

@felippeduarte
Copy link

+1

@ayrtonvwf
Copy link

@neves any chance this PR gets merged?

@JosNun
Copy link

JosNun commented Nov 9, 2018

Hasn't been touched for ~6 months... Is it dead?

EDIT: A relatively simple workaround is just using a regular input if no mask is passed.

<template>
  <div>
    <the-mask
      v-if="mask"
      :name="name"
      :value="value"
      :mask="mask"
      @input="handleInput"
    />
    <input
      v-else
      :name="name"
      :value="value"
      @input="handleInput($event.target.value)"
    />
    </div>
</template>

<script>
import Vue from 'vue';
export default Vue.extend({
  methods: {
    handleInput(value) {
      this.$emit('input', value);
    },
  },
  props: {
    mask: {
      type: String,
      default: '',
    },
    name: {
      required: true,
      type: String,
    },
    value: {
      default: '',
    },
  },
});
</script>

@pleek91
Copy link

pleek91 commented Dec 10, 2018

Is this project even active? Seems like no one with access to merge has reviewed this PR.

@devsoitic08
Copy link

Why isn't this getting merged?

@EdwinHauspie
Copy link

@JosNun yes, we did it this way

@vjnrv
Copy link

vjnrv commented Dec 13, 2018

+1

1 similar comment
@diafrit
Copy link

diafrit commented Dec 17, 2018

+1

@diguifi
Copy link

diguifi commented Dec 21, 2018

+1 (this PR is over a year forgotten tho)

@ZackStone
Copy link

+1

1 similar comment
@pedroramostracker
Copy link

+1

@pedroramostracker
Copy link

Hasn't been touched for ~6 months... Is it dead?

EDIT: A relatively simple workaround is just using a regular input if no mask is passed.

<template>
  <div>
    <the-mask
      v-if="mask"
      :name="name"
      :value="value"
      :mask="mask"
      @input="handleInput"
    />
    <input
      v-else
      :name="name"
      :value="value"
      @input="handleInput($event.target.value)"
    />
    </div>
</template>

<script>
import Vue from 'vue';
export default Vue.extend({
  methods: {
    handleInput(value) {
      this.$emit('input', value);
    },
  },
  props: {
    mask: {
      type: String,
      default: '',
    },
    name: {
      required: true,
      type: String,
    },
    value: {
      default: '',
    },
  },
});
</script>

i used the same perspective,
2 inputs, one for mask != null
other for null

@zhiga90
Copy link

zhiga90 commented Apr 8, 2019

more than a year has passed

@wenderpmachado
Copy link

sad but true

@kaskar2008
Copy link

We have created a fork and published a package with the reference to the author of this project. Also we have merged some major PRs into our fork. If you need more features - feel free to contribute, we are open to PR :)

Package
Repo

@feliperaul
Copy link

Very sad to see a good project like this die in this way.

This PR is literally 2 lines of code and fixes a common bug many people are facing.

@galloaleonardo
Copy link

Same issue here!

@leoclo
Copy link

leoclo commented Jul 17, 2020

+1

@rodrigorodriguescosta
Copy link

I had the same error and the outhor of the project has abandoned the nice library, well, I just created a new fork to make that changes but hopeffuly I noticed this PR already did it and @kaskar2008 already created the package, I'm using the ke-the-mask instead. so sad for this project

@SinkP
Copy link

SinkP commented Jan 28, 2022

Still waiting

@aslupin
Copy link

aslupin commented Nov 15, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet