Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples-basic #103

Merged

Conversation

alirezahamid
Copy link
Contributor

Please review my translations for Examples/Basic in this PR. Please note, i was not sure which part really needed to be translated or not. So please fell free to drop me a comment and i fix it ASAP. Thanks :)

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 10:32pm

@mostafa-nematpour
Copy link
Member

Hi Alireza,
As you can see, Persian and English words are not displayed correctly in ltr (left-to-right).

This is for /examples/#hello-world.
Screenshot_2023-12-06_08_37_04

If you change your text to the text below, it might get fixed.

!به جهان سلام کنید Vue با استفاده از

One could say, in a way, you should start writing section by section from the end of the sentence.

This link could be helpful.
https://github.com/javascript-tutorial/fa.javascript.info#%D8%AA%D8%B1%D8%AC%D9%85%DB%80-%DA%A9%D8%A7%D9%85%D9%86%D8%AA%D9%87%D8%A7-%D8%AF%D8%B1-%DA%A9%D8%AF

Thank you.

@mostafa-nematpour mostafa-nematpour added the changes requested need to changes. label Dec 6, 2023
class bindings have special support for objects and arrays
in addition to plain strings
-->
کلاس پشتیبانی ویژه‌ای برای اشیاء و آرایه‌ها
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the "class bindings" that support arrays and objects, not the normal class itself.

</p>

<!-- style bindings also support object and arrays -->
<!-- استایل نیز از اشیاء و آرایه‌ها پشتیبانی می‌کنند -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here for the technical aspects, we need to mention the "bindings" in translation (as mentioned in the original text) not only the normal style.

multiple checkboxes can bind to the same
array v-model value
چندین جعبه انتخاب می‌توانند به همان
مقدار v-model آرایه متصل شوند
-->
<h2>Multi Checkbox</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing translation for this section and the following sections in this file.

می‌توانیم اتصالات دو طرفه بین state و ورودی‌های فرم را با استفاده از دایرکتیو v-model ایجاد کنیم.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to add the English version of "two-way bindings" as its a technical word to inform the user about the term used in vue ecosystem

-->
<button @click="reverseMessage">Reverse Message</button>

<!-- Can also be an inline expression statement -->
<!-- همچنین می تواند یک عبارت عبارت درونی باشد -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need to review this line since it's not correctly translated as the "inline expression statement". you may also mention the English term here if it's necessary.

@mostafa-nematpour mostafa-nematpour added changes requested need to changes. and removed changes requested need to changes. labels Dec 10, 2023
@mostafa-nematpour
Copy link
Member

I close this, we can continue whenever you come back.

@mostafa-nematpour mostafa-nematpour merged commit 6812caf into vuejs-translations:main Jan 19, 2024
2 checks passed
@mostafa-nematpour
Copy link
Member

Hello @alirezahamid , I hope you're doing well.
It's been a while since we heard from you, so I took the initiative to address some translation issues myself and ultimately merged the changes.
Thank you for your contribution, and I wish best.

@mostafa-nematpour
Copy link
Member

@mostafa-rio

Thank you for your review. I tried to address the points you mentioned and fix them.

@mostafa-nematpour mostafa-nematpour changed the title translation for examples/basic examples-basic Jan 19, 2024
@mostafa-nematpour mostafa-nematpour removed the changes requested need to changes. label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants