Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composable): fix infinite loading in ssr #1241

Closed
wants to merge 1 commit into from
Closed

fix(composable): fix infinite loading in ssr #1241

wants to merge 1 commit into from

Conversation

negezor
Copy link

@negezor negezor commented Aug 16, 2021

There is no $isServer property in the Composition API for Vue 2. This causes an infinite load on the server.

https://github.com/vuejs/composition-api/blob/master/CHANGELOG.md#100-beta22-2020-12-19

// vm.$isServer undefined
console.log('vm.$isServer', vm.$isServer);
// vm.proxy.$isServer true
console.log('vm.proxy.$isServer', vm.proxy.$isServer);

Issue with reproducible error #1222, repository https://github.com/negezor/nuxt-apollo-3-slow-ssr

@negezor
Copy link
Author

negezor commented Aug 17, 2021

@Akryum could you check that?

@Akryum
Copy link
Member

Akryum commented Sep 20, 2021

Thanks for the PR! I fixed the issue differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants