fixed subscriptions leak #1248
Merged
fixed subscriptions leak #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For example code from URL https://apollo.vuejs.org/guide/components/subscribe-to-more.html#examples-of-updatequery on changing variables in query and subscriptions. On changing variables in query each subscriptions(in this._linkedSubscriptions) stopping and starting after query. On addSmartSubscription we push to _linkedSubscriptions current subscription. On change variables in ApolloSubscribeToMore we triggered addSmartSubscription and old subscriptions pushed in this._linkedSubscriptions.
Resolve
deduplicate this._linkedSubscriptions on adding to _linkedSubscriptions