fix: provideApollClient overriding specified query / mutation clientId #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See description here: vuejs#1337 (comment)
dcress
changed the title
dcress
changed the title
|
Closing this in favor of: #1340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original issue here: #1337
Problem:
Vue Apollo is using the
savedCurrentClientas the default client even when inside of a .vue file and a different clientId is being explicitly set by the query or mutation. This means that if you've set the client by usingprovideApolloClientat any point in the application's session, it's going to continue to use that client instead of the one you're specifying in the current query or mutation because thatsavedCurrentClientconst is based on thecurrentApolloClientvar.Solution:
I believe that these conditions should be swapped to look for a provided ID first and if one isn't provided then try and fallback to the savedCurrentClient.