Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes issue #1244 #1303

Merged
merged 6 commits into from Jul 20, 2017
Merged

Closes issue #1244 #1303

merged 6 commits into from Jul 20, 2017

Conversation

edgardleal
Copy link
Contributor 

This plugin was included in section ## Integrations

as instructed in comment below the Integrations session.

Instructions for CONTRIBUTING.md:

  • Documentations ( README and CONTRIBUTING ) Ok
  • Documentation is in English Ok
  • Project is active and mantained Ok
  • Project accepts contrubutions Ok

@edgardleal
Added require-vuejs
1c76054 
  This is a RequireJS plugin to integrate with VueJS loading
and parse single file components ( .vue ).

  Inserted in Integrations category.
@edgardleal
Replace tab for space
0b0f169 
  The instalaction of vim that I am using was with
a wrong setup. Now it is fixed.
@edgardleal
🔃 merging with original repository
498fe32
@edgardleal
🔃 integrate with original repository
ae54c86
@edgardleal
closes issue vuejs#1244
a6d0771 
    This plugin was included in section ## Integrations
 as instructed in comment below the Integrations session.

  Instructions for CONTRIBUTING.md:

  * Documentations ( README and CONTRIBUTING ) Ok
  * Documentation is in English Ok
  * Project is active and mantained Ok
  * Project accepts contrubutions Ok
@edgardleal edgardleal mentioned this pull request Jul 18, 2017
Closed
nickmessing
nickmessing suggested changes Jul 18, 2017
View reviewed changes
Copy link
Member

@nickmessing nickmessing left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you need to follow all CONTRIBUTING.md rules

  1. Always add your items to the end of a list. To be fair, the order is first-come-first-serve.

It may sound unfair because it was removed but this is a rule that we need to follow.

@edgardleal
Copy link
Contributor Author

I don't see any item inside Integrations session, and I think the session Integrations should be the best place to include it.

If I am wrong, please tell me where should I include it.
Ex.: After plugin x

Thank you for your feedback.

@nickmessing
Copy link
Member

@edgardleal, Add it after vue-recaptcha please.

@edgardleal
Copy link
Contributor Author

@nickmessing , I am sorry for wasting your time on my lack of attention.
It is fixed.

@nickmessing nickmessing merged commit ecfc4f3 into vuejs:master Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmessing nickmessing nickmessing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edgardleal @nickmessing