[WIP] feat: Provide installation instructions on missing language preprocessors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
reviewed
May 2, 2018
lib/compileTemplate.ts
Outdated
| ), | ||
| source: options.source, | ||
| tips: [`Please install ${preprocessLang}`], | ||
| errors: [`Please install ${preprocessLang}`] |
There was a problem hiding this comment.
The error message should tell what is not working.
And then the tip can suggest how to fix it.
There was a problem hiding this comment.
Updated, wanted to make sure I had my logic correct first
znck
requested changes
May 4, 2018
test/compileTemplate.spec.ts
Outdated
| expect(result.errors.length).toBe(0) | ||
| }) | ||
|
|
||
| test('preprocess pug', () => { |
There was a problem hiding this comment.
The test name can be set to 'warn missing preprocessor'.
There was a problem hiding this comment.
Updated test name
znck
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.