fix(trim): don't insert line break #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
approved these changes
Dec 11, 2018
|
Ok, so the original intention for the Always setting it to an empty string will make the dynamic inserted CSS in development harder to read. So in 2603ee2 I've made it so that it only sets it to a newline when the whitespace has not been already trimmed (e.g. by cssnano). |
|
Fix is out in 2.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the component CSS is separated by a line break (caused by the
trimstylePlugin).Though this can be helpful for debugging, the characters are not necessary at all (at least from what I know).
Current state
With fix
Related issues and PRs
#36
vuejs/vue-loader#1395
cssnano/cssnano#586
nuxt/nuxt#4311