Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change duplicate installation from error to warn, close #631 #632

Merged
merged 2 commits into from Jan 14, 2021
Merged

fix: change duplicate installation from error to warn, close #631 #632

merged 2 commits into from Jan 14, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 14, 2021

No description provided.

@antfu antfu requested a review from pikax January 14, 2021 12:44
@antfu antfu marked this pull request as draft January 14, 2021 12:48
@antfu antfu marked this pull request as ready for review January 14, 2021 12:52
pikax
pikax reviewed Jan 14, 2021
View reviewed changes
Copy link
Member

@pikax pikax left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see the error to warn change

Didn't notice the assert and warn :D

@antfu antfu merged commit 5301d49 into vuejs:master Jan 14, 2021
@antfu antfu deleted the fix/warn branch January 14, 2021 16:15
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antfu @pikax