Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runtime-vapor vModel bug #135

Closed
wants to merge 0 commits into from

Conversation

FireBushtree
Copy link
Contributor

@FireBushtree FireBushtree commented Feb 22, 2024

closes #134

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit e91dde5
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/65d83ed53ab3b400088eaa3e
😎 Deploy Preview https://deploy-preview-135--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit e91dde5
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/65d83ed5dd16d30008023571
😎 Deploy Preview https://deploy-preview-135--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 22, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.1 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 47.4 kB 16.1 kB 14.6 kB
runtime-dom.global.prod.js 91.4 kB 34.7 kB 31.3 kB
runtime-vapor.global.prod.js 35.4 kB (+350 B) 13.5 kB (+122 B) 12.4 kB (+123 B)
vue-vapor.global.prod.js 80.3 kB (+356 B) 28.2 kB (+121 B) 25.5 kB (+120 B)
vue.global.prod.js 149 kB 54 kB 48.2 kB

Usages

Name Size Gzip Brotli
createApp 51.6 kB 20.1 kB 18.4 kB
createSSRApp 55 kB 21.4 kB 19.5 kB
defineCustomElement 53.9 kB 20.8 kB 19.1 kB
vapor 35.5 kB (+346 B) 13.6 kB (+124 B) 12.4 kB (+114 B)
overall 65.4 kB 25.2 kB 22.8 kB

@FireBushtree
Copy link
Contributor Author

@sxzz Did these errors caused by my code?

@sxzz
Copy link
Member

sxzz commented Feb 23, 2024

This is not a correct fix, see this reproduction. Still print old value

@FireBushtree
Copy link
Contributor Author

This is not a correct fix, see this reproduction. Still print old value

i will try to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] runtime-vapor/vModel
2 participants