Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-vapor): trigger updated hooks across components #165

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

Ubugeeei
Copy link
Member

resolve #163

The mounted flag of the sub-component was not being updated.

I noticed that tests for the apiLifecycle were not implemented, so I created an issue for it.
-> #164

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit fe35414
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/65ffd7b192a8220008f0ae84
😎 Deploy Preview https://deploy-preview-165--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit fe35414
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/65ffd7b1bac9000008f3a13c
😎 Deploy Preview https://deploy-preview-165--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ubugeeei Ubugeeei added bug Something isn't working runtime labels Mar 24, 2024
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 48.9 kB 16.7 kB 15.1 kB
runtime-dom.global.prod.js 94.5 kB 35.6 kB 32 kB
runtime-vapor.global.prod.js 41.4 kB (+39 B) 15.4 kB (+8 B) 14.1 kB (+5 B)
vue-vapor.global.prod.js 87.8 kB (+39 B) 30.7 kB (+9 B) 27.8 kB (+28 B)
vue.global.prod.js 152 kB 54.9 kB 49 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.3 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 41.6 kB (+39 B) 15.5 kB (+6 B) 14.2 kB (+11 B)
overall 68.5 kB 26.1 kB 23.6 kB

@Ubugeeei
Copy link
Member Author

When registering lifecycle hooks in a sub-component, I also noticed that they are registered on the parent instance.
I wonder if this is intentional. 🤔

@sxzz sxzz merged commit ba17fb9 into main Mar 24, 2024
11 checks passed
@sxzz sxzz deleted the ubugeeei/fix/136-render-effect-job branch March 24, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The onUpdated hook is not triggered across components.
2 participants