feat: support usage of v-once with v-if
#200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LittleSound
requested changes
May 6, 2024
Size ReportBundles
Usages
|
|
Thank you, sxzz, for helping me with the modifications. |
LittleSound
approved these changes
May 7, 2024
sxzz
force-pushed
the
feat/v-once-with-v-if/else
branch
from
a212832
to
fc638b8
Compare
sxzz
force-pushed
the
feat/v-once-with-v-if/else
branch
from
fc638b8
to
69a8908
Compare
sxzz
approved these changes
May 12, 2024
sxzz
reviewed
May 12, 2024
| @@ -36,7 +36,8 @@ export function genIf( | |||
| vaporHelper('createIf'), | |||
| conditionExpr, | |||
| positiveArg, | |||
| negativeArg, | |||
| negativeArg || (once ? 'null' : false), | |||
There was a problem hiding this comment.
Should add a placeholder if once is true but no negative branch.
sxzz
changed the title
v-once with v-if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented basic v-once support for v-if/else via a once flag, please review and advise if any scenarios are unaddressed.