Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime-vapor): resolve assets of components & directives #214

Merged
merged 4 commits into from
May 28, 2024

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented May 19, 2024

close #209

  • runtime
  • test case

@Doctor-wu Doctor-wu changed the title feat(runtime-vapor): resolve-components resolve-directives feat(runtime-vapor): resolve-components & resolve-directives May 19, 2024
Copy link

netlify bot commented May 19, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit f28d751
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/665617192d87f200080987ba
😎 Deploy Preview https://deploy-preview-214--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 19, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit f28d751
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/66561719d1dfce00083a9693
😎 Deploy Preview https://deploy-preview-214--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 19, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 57 kB 19.4 kB 17.5 kB
runtime-dom.global.prod.js 94.9 kB 35.8 kB 32.3 kB
runtime-vapor.global.prod.js 47.9 kB (+485 B) 17.9 kB (+167 B) 16.3 kB (+137 B)
vue-vapor.global.prod.js 102 kB (+470 B) 35.7 kB (+164 B) 32.2 kB (+149 B)
vue.global.prod.js 152 kB 55.1 kB 49.2 kB

Usages

Name Size Gzip Brotli
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 58.6 kB 22.5 kB 20.5 kB
defineCustomElement 57.6 kB 21.9 kB 20 kB
vapor 48.2 kB (+484 B) 17.9 kB (+158 B) 16.4 kB (+149 B)
overall 69.1 kB 26.2 kB 23.8 kB

@Ubugeeei
Copy link
Member

It might have overlapped.
(I'll close mine then.)
#213
#212

@Ubugeeei
Copy link
Member

It might have overlapped.

Both were closed. This PR is the master.
Please proceed without worrying about it ;D

@Ubugeeei Ubugeeei mentioned this pull request May 20, 2024
75 tasks
@sxzz sxzz marked this pull request as draft May 21, 2024 00:36
@Doctor-wu Doctor-wu marked this pull request as ready for review May 27, 2024 14:27
@sxzz sxzz merged commit 107569b into main May 28, 2024
11 checks passed
@sxzz sxzz changed the title feat(runtime-vapor): resolve-components & resolve-directives feat(runtime-vapor): resolve assets of components & directives May 28, 2024
@sxzz sxzz deleted the feature-resolve-asset branch May 28, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets Management
3 participants