fix(runtime-dom): v-cloak should be removed after compile on the root…

… element fix #890
vuejs · Mar 31, 2020 · 380ed52 · 380ed52
1 parent 412ec86
commit 380ed52
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/runtime-dom/__tests__/directives/vCloak.spec.ts b/packages/runtime-dom/__tests__/directives/vCloak.spec.ts
@@ -0,0 +1,10 @@
+import { createApp } from '@vue/runtime-dom'
+
+describe('vCloak', () => {
+  test('should be removed after compile', () => {
+    const root = document.createElement('div')
+    root.setAttribute('v-cloak', '')
+    createApp({}).mount(root)
+    expect(root.hasAttribute('v-cloak')).toBe(false)
+  })
+})
diff --git a/packages/runtime-dom/src/index.ts b/packages/runtime-dom/src/index.ts
@@ -63,7 +63,9 @@ export const createApp = ((...args) => {
     }
     // clear content before mounting
     container.innerHTML = ''
-    return mount(container)
+    const proxy = mount(container)
+    container.removeAttribute('v-cloak')
+    return proxy
   }
 
   return app