fix(compiler-sfc): should not remove import statements with no specif…

…ier when compiling script setup
vuejs · Nov 28, 2020 · 43eab92 · 43eab92
1 parent a76e58e
commit 43eab92
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap b/packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap
@@ -181,10 +181,13 @@ return { a, b }
 
 exports[`SFC compile <script setup> imports should hoist and expose imports 1`] = `
 "import { ref } from 'vue'
+          import 'foo/css'
+        
 export default {
   expose: [],
   setup(__props) {
 
+          
 return { ref }
 }
 

diff --git a/packages/compiler-sfc/__tests__/compileScript.spec.ts b/packages/compiler-sfc/__tests__/compileScript.spec.ts
@@ -123,7 +123,10 @@ const myEmit = defineEmit(['foo', 'bar'])
   describe('imports', () => {
     test('should hoist and expose imports', () => {
       assertCode(
-        compile(`<script setup>import { ref } from 'vue'</script>`).content
+        compile(`<script setup>
+          import { ref } from 'vue'
+          import 'foo/css'
+        </script>`).content
       )
     })
 

diff --git a/packages/compiler-sfc/src/compileScript.ts b/packages/compiler-sfc/src/compileScript.ts
@@ -638,7 +638,7 @@ export function compileScript(
           )
         }
       }
-      if (removed === node.specifiers.length) {
+      if (node.specifiers.length && removed === node.specifiers.length) {
         s.remove(node.start! + startOffset, node.end! + startOffset)
       }
     }