Skip to content
Permalink
Browse files
fix(hmr): fix HMR for nested non-SFC components (#4077)
  • Loading branch information
turrsis committed Aug 30, 2022
1 parent 0739f89 commit 96eb7452548293c343613ab778248a5da9619f45
Showing 1 changed file with 8 additions and 5 deletions.
@@ -192,6 +192,13 @@ export function initProps(
instance.attrs = attrs
}

function isInHmrContext(instance: ComponentInternalInstance | null) {
while (instance) {
if (instance.type.__hmrId) return true
instance = instance.parent
}
}

export function updateProps(
instance: ComponentInternalInstance,
rawProps: Data | null,
@@ -211,11 +218,7 @@ export function updateProps(
// always force full diff in dev
// - #1942 if hmr is enabled with sfc component
// - vite#872 non-sfc component used by sfc component
!(
__DEV__ &&
(instance.type.__hmrId ||
(instance.parent && instance.parent.type.__hmrId))
) &&
!(__DEV__ && isInHmrContext(instance)) &&
(optimized || patchFlag > 0) &&
!(patchFlag & PatchFlags.FULL_PROPS)
) {

0 comments on commit 96eb745

Please sign in to comment.