chore: optimize widht/height element check

vuejs · Nov 30, 2023 · 9845f1d · 9845f1d
1 parent 38aaa8c
commit 9845f1d
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/packages/runtime-dom/src/patchProp.ts b/packages/runtime-dom/src/patchProp.ts
@@ -13,8 +13,6 @@ const isNativeOn = (key: string) =>
   key.charCodeAt(2) > 96 &&
   key.charCodeAt(2) < 123
 
-const embeddedTags = ['IMG', 'VIDEO', 'CANVAS', 'SOURCE']
-
 type DOMRendererOptions = RendererOptions<Node, Element>
 
 export const patchProp: DOMRendererOptions['patchProp'] = (
@@ -113,11 +111,11 @@ function shouldSetAsProp(
   }
 
   // #8780 the width or heigth of embedded tags must be set as attribute
-  if (
-    (key === 'width' || key === 'height') &&
-    embeddedTags.includes(el.tagName)
-  ) {
-    return false
+  if (key === 'width' || key === 'height') {
+    const tag = el.tagName
+    return (
+      tag === 'IMG' || tag === 'VIDEO' || tag === 'CANVAS' || tag === 'SOURCE'
+    )
   }
 
   // native onclick with string value, must be set as attribute