-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Vue License #10054
Comments
The license inclusion requirement only applies to users using the software, not the copyright owner distributing it. Technically the license is already distributed as part of the npm package (e.g. https://unpkg.com/browse/vue@3.4.7/LICENSE), but I guess we can include a small banner in individual files as well. |
Yes, but users who use vue, will end up without a license in their js code . The end customer who visits the users webpage doesnt know about npm and certainly cant tell from the minified code that it's vue (or any other package). |
Even if we include the banner in dist files, bundlers are not guaranteed to preserve them. This is not something we can enforce so like you said, this is probably not the place to discuss that. |
Even worse in the bundlers case I'd say. From what I can tell vite/rollup at least preserves any comments starting with |
Vue version
Any
Link to minimal reproduction
/
Steps to reproduce
Checkout CDN code: https://unpkg.com/vue@3.4.7/dist/vue.global.js.
What is expected?
There should be information about the license of the code in js file, imo.
What is actually happening?
There's no license information in the CDN code nor in the bundle which is generated by vite for example.
Unless I'm completely mistaken it should be included like the license says
Pinia for example has at least this
https://github.com/vuejs/pinia/blob/v2/rollup.config.mjs#L44
which results in the following to appear after building
System Info
Any additional comments?
sorry if this isnt perhaps the right replace to mention this.
The text was updated successfully, but these errors were encountered: