Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Vue License #10054

Closed
Disservin opened this issue Jan 9, 2024 · 4 comments
Closed

Missing Vue License #10054

Disservin opened this issue Jan 9, 2024 · 4 comments
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.

Comments

@Disservin
Copy link
Contributor

Vue version

Any

Link to minimal reproduction

/

Steps to reproduce

Checkout CDN code: https://unpkg.com/vue@3.4.7/dist/vue.global.js.

What is expected?

There should be information about the license of the code in js file, imo.

What is actually happening?

There's no license information in the CDN code nor in the bundle which is generated by vite for example.
Unless I'm completely mistaken it should be included like the license says

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

Pinia for example has at least this
https://github.com/vuejs/pinia/blob/v2/rollup.config.mjs#L44
which results in the following to appear after building

/*!
 * pinia v2.1.7
 * (c) 2023 Eduardo San Martin Morote
 * @license MIT
 */

System Info

/

Any additional comments?

sorry if this isnt perhaps the right replace to mention this.

@yyx990803
Copy link
Member

The license inclusion requirement only applies to users using the software, not the copyright owner distributing it. Technically the license is already distributed as part of the npm package (e.g. https://unpkg.com/browse/vue@3.4.7/LICENSE), but I guess we can include a small banner in individual files as well.

@yyx990803 yyx990803 added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Jan 9, 2024
@Disservin
Copy link
Contributor Author

Yes, but users who use vue, will end up without a license in their js code . The end customer who visits the users webpage doesnt know about npm and certainly cant tell from the minified code that it's vue (or any other package).
So right now essentially every vue user is missing license information about vue in their js files and according to this https://greendrake.info/publications/js-gpl#does-using-javascript-code-on-a-website-constitute-distribution-of-the-code-to-the-website-visitors it technically counts as distributing code (in case it's client side and not CDN).
I think the entire situation is bit more dire since very few packages actually include such a banner, so important copyright information is missing from a lot of websites.

@yyx990803
Copy link
Member

Even if we include the banner in dist files, bundlers are not guaranteed to preserve them. This is not something we can enforce so like you said, this is probably not the place to discuss that.

@Disservin
Copy link
Contributor Author

Even worse in the bundlers case I'd say. From what I can tell vite/rollup at least preserves any comments starting with @license, like the pinia banner.

yyx990803 added a commit that referenced this issue Jan 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
None yet
Development

No branches or pull requests

2 participants